httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 44579] mod_cache doesn't handle If-Range correctly
Date Wed, 12 Mar 2008 22:13:13 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=44579


Ruediger Pluem <rpluem@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|FixedInTrunk, PatchAvailable|




--- Comment #8 from Ruediger Pluem <rpluem@apache.org>  2008-03-12 15:13:13 PST ---
Better check the following patch:

Index: modules/cache/cache_storage.c
===================================================================
--- modules/cache/cache_storage.c       (Revision 636503)
+++ modules/cache/cache_storage.c       (Arbeitskopie)
@@ -286,6 +286,12 @@
                 apr_table_unset(r->headers_in, "If-Range");
                 apr_table_unset(r->headers_in, "If-Unmodified-Since");

+                /* Do not do Range requests with our own conditionals: If
+                 * we get 304 the Range does not matter and otherwise the
+                 * entity changed and we want to have the complete entity
+                 */
+                apr_table_unset(r->headers_in, "Range");
+
                 etag = apr_table_get(h->resp_hdrs, "ETag");
                 lastmod = apr_table_get(h->resp_hdrs, "Last-Modified");


I made up my mind and in case we set our own conditionals for the request to
the backend a Range request makes no sense for the reason stated in the
comment.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message