httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 44015] - Bug in util_ldap.c, mod_ldap
Date Tue, 04 Dec 2007 18:49:19 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44015>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44015


agustin.herranz@alumnos.uva.es changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |trivial
             Status|RESOLVED                    |REOPENED
           Priority|P2                          |P3
         Resolution|FIXED                       |




------- Additional Comments From agustin.herranz@alumnos.uva.es  2007-12-04 10:49 -------
(In reply to comment #1)
> This is fixed in the most recent release of apr-util (1.2.12), there was a
> lengthy discussion on the issue but several SDKS support -1 (use connection
> default limit) and don't always have LDAP_DEFAULT_LIMIT defined.
> 
> (the other SDKS don't send the -1 over the wire)

Microsoft LDAP SDK send -1 (0xFFFFFFFF) over the wire...
I have build apr, apr-util, mod_ldap and mod_authnz_ldap with Visual C++ 2005
Express and tested with apache 2.2.6 on an W2k server with Openldap server and
works well.

Still had to delete APR_LDAP_SIZELIMIT definition on util_ldap.c like said th
comment, and sync apr_ldap.hw to an apr_ldap.h.in style for:

#if APR_HAS_ZOS_LDAPSDK || APR_HAS_MICROSOFT_LDAPSDK
#define APR_LDAP_SIZELIMIT LDAP_NO_LIMIT
#else
#ifdef LDAP_DEFAULT_LIMIT
#define APR_LDAP_SIZELIMIT LDAP_DEFAULT_LIMIT
#else
#define APR_LDAP_SIZELIMIT -1 /* equivalent to LDAP_DEFAULT_LIMIT */
#endif
#endif

or better:


#ifdef LDAP_DEFAULT_LIMIT
#define APR_LDAP_SIZELIMIT LDAP_DEFAULT_LIMIT
#else
#if APR_HAS_XXX_LDAPSDK /* who dont have defined LDAP_DEFAULT_SIZELIMIT but
support -1 */
#define APR_LDAP_SIZELIMIT -1 /* equivalent to LDAP_DEFAULT_LIMIT */
#else
#define APR_LDAP_SIZELIMIT LDAP_NO_LIMIT
#endif
#endif

I thought this version is better because LDAP_DEFAULT_SIZELIMIT = -1 is defined
in a draft that update RFC1823 what is an informational document, as far i can
see, and LDAP_NO_LIMIT = 0 is defined in RFC2251 - RFC4511 LDAP v3 protocol what
is a proposed standard.




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message