httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 42027] - FileETag directive appears to be ignored
Date Tue, 31 Jul 2007 18:32:43 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42027>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42027





------- Additional Comments From rici@ricilake.net  2007-07-31 11:32 -------
I believe this is a copy&paste error at line 392 of server/core.c (in trunk,
line 420 in 2.2.4):
391 : conf->etag_remove =
392 :   	(conf->opts_remove & (~ new->etag_add)) | new->etag_remove;

line 392 should read:

392 :   	(conf->etag_remove & (~ new->etag_add)) | new->etag_remove;

In addition, I believe there is an error in the parsing of FileETag, at:

1599 :  if ((cfg->etag_bits & ETAG_NONE) != ETAG_NONE) {
1600 :  	cfg->etag_bits &= (~ ETAG_NONE);

That's a no-op; I think line 1599 should read:

1599 :  if (cfg->etag_bits != ETAG_NONE) {

However, the correction of cfg->etag_bits at in the merge (line 402/403) should
mask the effects of this error in the majority of cases.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message