httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 41960] - Apache is not using custom content-types when accessing content-negotiated resources
Date Mon, 04 Jun 2007 23:32:10 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41960>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41960





------- Additional Comments From jose@w3.org  2007-06-04 16:32 -------
Sorry for the delay. My laptop broke down.

I continued my tests. I removed all the file_req optimizations in
request.c:ap_process_request_internal() and this solved the bug I had reported,
without any noticeable side-effect on our server. The aaa behavior I had
seen in our modules was due to something else. 

Here's the diff -Naur patch. Could you confirm if this patch works for you
(without any side effect) or provide further advice? I'm willing to continue
testing and trying code 
changes.

Thanks!

-jose

--- request.c.orig	2007-05-31 15:35:57.000000000 +0000
+++ request.c	2007-06-04 23:18:48.000000000 +0000
@@ -101,7 +101,6 @@
  */
 AP_DECLARE(int) ap_process_request_internal(request_rec *r)
 {
-    int file_req = (r->main && r->filename);
     int access_status;
 
     /* Ignore embedded %2F's in path for proxy requests */
@@ -133,16 +132,15 @@
      * next several steps.  Only file subrequests are allowed an empty uri,
      * otherwise let translate_name kill the request.
      */
-    if (!file_req) {
-        if ((access_status = ap_location_walk(r))) {
-            return access_status;
-        }
+    if ((access_status = ap_location_walk(r))) {
+      return access_status;
+    }
 
-        if ((access_status = ap_run_translate_name(r))) {
-            return decl_die(access_status, "translate", r);
-        }
+    if ((access_status = ap_run_translate_name(r))) {
+      return decl_die(access_status, "translate", r);
     }
 
+
     /* Reset to the server default config prior to running map_to_storage
      */
     r->per_dir_config = r->server->lookup_defaults;
@@ -152,14 +150,10 @@
         return access_status;
     }
 
-    /* Excluding file-specific requests with no 'true' URI...
+    /* Rerun the location walk, which overrides any map_to_storage config.
      */
-    if (!file_req) {
-        /* Rerun the location walk, which overrides any map_to_storage config.
-         */
-        if ((access_status = ap_location_walk(r))) {
-            return access_status;
-        }
+    if ((access_status = ap_location_walk(r))) {
+      return access_status;
     }
 
     /* Only on the main request! */



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message