httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 42425] New: - Additional freshness checks in mod_cache.c cause must-revalidate or max-age=0 content to not get stored.
Date Tue, 15 May 2007 16:25:43 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42425>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42425

           Summary: Additional freshness checks in mod_cache.c cause must-
                    revalidate or max-age=0 content to not get stored.
           Product: Apache httpd-2
           Version: 2.3-HEAD
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: mod_cache
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: basam@stream.aol.net


Here is the relevant output from diff of the 2.2.3 from the 2.2.4 version of
mod_cache.c

diff httpd-2.2.3/modules/cache/mod_cache.c httpd-2.2.4/modules/cache/mod_cache.c

428a431,435
>     else if (exp != APR_DATE_BAD && exp < r->request_time)
>     {
>         /* if a Expires header is in the past, don't cache it */
>         reason = "Expires header already expired, not cacheable";
>     }

The above check is comparing the the expires time from the server (in second
granularity) to the request_time from the client ( upto micro second
granularity). Even though we have all of our hosts running NTP, it is possible
to get a very small skew which is enough to cause this check to pass and the
object ends up not getting put into local cache.

We have a workaround by commenting out the above code, but i don't believe this
check is needed when you have an explicit expires or Cache-Control header from
the server.

regards,
         Sridhar

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message