httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 41698] - Site documentation of Header edit is missing
Date Sat, 31 Mar 2007 19:05:05 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41698>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41698





------- Additional Comments From rpluem@apache.org  2007-03-31 12:05 -------
(In reply to comment #15)
> Ruediger, good day.
> 
> (In reply to comment #14)
> > Many thanks for your continued work on this. Sorry, I guess it is my fault that
> > I did not explain the problem clearly enough. To be honest I have not looked at
> > your patch in detail now, but however perfect it may be for the mod_rewrite case
> > it will not fix the problem, because mod_rewrite is only *one* module that could
> > break. The final solution needs to deal with *any* module that adjusts the
> > original uri during request processing, so even third party modules and modules
> > that have not been written yet.
> 
> The problem is that the modules are rewriting the URLs differently. And there is
> no generic way to tell how. For example, ap_proxy_http_request can rewrite the
> 'Destination' header for the mod_proxy's own rewriting, but it will completely
> fail to do it for the mod_rewrite's rewriting: it has no knowledge about the
> rewriting rule that were used. And in the case of *any* module that uses
> mod_proxy rewriting hooks, there is absolutely no way to get the proper
> rewriting of the 'Destination' header. And, I think, it is the module's matter
> to rewrite all headers properly. Why should mod_proxy care of mod_rewrite's (or
> whatever module's) internals?

It shouldn't. But it needs to be ensured that the URL of the Destination header
gets rewritten in the same way as a request for this URL would be rewritten by
whatever module does this.

> 
> > But digging somewhat deeper I noticed that since 2.2.x the Destination header
> > gets rewritten in the same way as the Location header. So you can configure this
> > properly via ProxyPassReverse (which you need to do anyway to get the redirects
> > fixed). Of course there is still a documentation bug as the documentaion of
> > ProxyPassReverse fails to document this behaviour.
> 
> Yes, but it is rewritten when the request is passed from the backend server to
> the main one, that is the ProxyPassReverse is about, isn't it? And I am talking
> about the header rewriting on the 'main server' -> 'backend server' path.

You are correct. I was on the wrong track here. You need the rewrite in the
forward (request) case not in the response case where ProxyPassReverse gets into
the game.

> 
> Any comments?

In order to have a broader audience for this discussion it should be moved to
the dev list. Mind to post a summary to dev@httpd.apache.org?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message