httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 31268] - ab: add an option to override the target host
Date Tue, 06 Feb 2007 16:35:53 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=31268>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31268


sander@temme.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sander@temme.net
             Status|NEW                         |NEEDINFO




------- Additional Comments From sander@temme.net  2007-02-06 08:35 -------
-1 on implementation, but +1 on concept. Arvind, I think your solution is pretty elegant,
and am in 
favor of using the existing -H option to override the headers in question. However, you are
no longer 
sending the Accept: and User-Agent headers to POST Requests when they are not overridden.


Also, the logic regarding the overridable headers in the if (posting <= 0) block is hard
to read because 
of the inversion (only print the headers when their opt_foo is NOT set). Perhaps you can pull
the part 
where you construct these headers outside the if (posting <= 0) block (bonus: you avoid
duplicating 
the logic), use proper if () statements instead of the ? operator and put a comment on both
branches of 
the if() to tell the reader what is going on like /* Header not overridden, print default
*/ and /* Header 
overridden, no need to send because it is already in the hdrs string */. 

Would you like to fix the above and resubmit?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message