httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 40865] New: - Missing assignment in error checking
Date Wed, 01 Nov 2006 19:24:29 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40865>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40865

           Summary: Missing assignment in error checking
           Product: Apache httpd-2
           Version: 2.2.3
          Platform: All
        OS/Version: other
            Status: NEW
          Severity: minor
          Priority: P2
         Component: mod_proxy
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: arjones@simultan.dyndns.org


I was going through the Apache source code looking for another bug, and some
code jumped out at me as being obviously wrong. Here's the (really short) patch:

--- proxy_util.c.orig   2006-11-01 20:05:21.000000000 +0100
+++ proxy_util.c        2006-11-01 20:05:56.000000000 +0100
@@ -955,7 +955,7 @@
                 *eos = 1;
             }
             else {
-                if (APR_SUCCESS != apr_bucket_read(e, (const char **)&response,
&len, APR_BLOCK_READ)) {
+                if (APR_SUCCESS != (rv = apr_bucket_read(e, (const char
**)&response, &len, APR_BLOCK_READ))) {
                     return rv;
                 }
                 /*


The same code is used a few lines earlier with the assignment i added in the
above patch, which convinces me that it really was an unintentional omission.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message