httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 40169] - CacheEnable not caching Forward proxy
Date Tue, 19 Sep 2006 19:33:00 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40169>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40169





------- Additional Comments From pg_asf@asf.for.sabi.co.UK  2006-09-19 19:33 -------
(In reply to comment #4)
> Created an attachment (id=18695)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18695&action=view) [edit]
> unified diff for cache_util.c
> 
> Sorry bout that - 1st time patch submitter.
> Here is the unified diff file for the patch.

The patch is not general enough I think. The language in the 
documentation leads to me think that *any* subprefix 
matches.

That "ht", "http:", "http://", "http://www.", "http://www.apa" 
all match "http://www.apache.org".

So the "strcasecmp(filter.hostname, url.hostname)" should be 
replaced by

  "strncasecmp(filter.hostname,
    url.hostname,strlen(filter.hostname))"

or equivalent. Actually this check should be applied to the 
whole URI, not just the 'hostname' part.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message