httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 40470] - isapi return wrong status when use ServerSupportFunction
Date Mon, 11 Sep 2006 19:58:38 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40470>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40470





------- Additional Comments From tpirapokin@kencast.com  2006-09-11 19:58 -------
The new mod_isapi-416293 still have problem with ServerSupportFunction at least
on HSE_REQ_SEND_RESPONSE_HEADER

For HSE_REQ_SEND_RESPONSE_HEADER, after send_response_header call, no handling
of ate == headlen. 

        if (ate < 0) {
            apr_set_os_error(APR_FROM_OS_ERROR(ERROR_INVALID_PARAMETER));
            return 0;
        }
        else if ((apr_size_t)ate < headlen) {
            apr_bucket_brigade *bb;
            apr_bucket *b;
            bb = apr_brigade_create(cid->r->pool, c->bucket_alloc);
            b = apr_bucket_transient_create((char*) data_type + ate,
                                           headlen - ate, c->bucket_alloc);
            APR_BRIGADE_INSERT_TAIL(bb, b);
            b = apr_bucket_flush_create(c->bucket_alloc);
            APR_BRIGADE_INSERT_TAIL(bb, b);
            rv = ap_pass_brigade(cid->r->output_filters, bb);
            cid->response_sent = 1;
            return (rv == APR_SUCCESS);
        }
    }

>From looking at the code for case HSE_REQ_SEND_RESPONSE_HEADER_EX, the return
"return (rv == APR_SUCCESS);", rv may not be initialized.

In my test with Apache 2.2.3, now I get status log as 1 on the access log, and
get real Internal Error from apache. I test with HSE_REQ_SEND_RESPONSE_HEADER
case and get ate == headlen (Is that suppose to be the normal correct case?)

Thanks,
TP

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message