httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 37758] - mod_rewrite trailing slash problem on external redirect in per-dir context
Date Thu, 31 Aug 2006 20:03:17 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=37758>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37758


bobsiegen@googlemail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |regression
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From bobsiegen@googlemail.com  2006-08-31 20:03 -------
This is actuallay a regression introduced with r104840,

The patch in trunk uses !is_proxyreq (r103199,
http://svn.apache.org/viewvc?view=rev&revision=103199 )
+    if (!is_proxyreq) {
+        l = strlen(dconf->directory) - 1;
+        if (r->filename && strlen(r->filename) == l &&
+            (dconf->directory)[l] == '/' &&
+            !strncmp(r->filename, dconf->directory, l)) {
+            return DECLINED;
+        }

while the backport (r104840,
http://svn.apache.org/viewvc?view=rev&revision=104840 ) uses
+    if (is_proxyreq) {
+        l = strlen(dconf->directory) - 1;

So the exclamation mark seems to be missing there. Marking as fixed, because
this problem is not present in trunk and the 2.2 branch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message