httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 26052] - DOCUMENT_ROOT environment variable set incorrectly with VirtualDocumentRoot
Date Mon, 24 Jul 2006 11:54:10 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=26052>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=26052


davidp@preshweb.co.uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |davidp@preshweb.co.uk




------- Additional Comments From davidp@preshweb.co.uk  2006-07-24 11:54 -------
(In reply to comment #17)
> Created an attachment (id=17663)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=17663&action=view) [edit]
> set document root with mod_vhost_alias
> 
> This has been causing problems for me with PHP.  I wrote a patch for
> mod_vhost_alias.c to dynamically set document_root.  The changed behavior is
> controlled by setting SetVirtualDocumentRoot to "on" or "true".  Patch is
> attached.

Nice one, I personally believe that functionality should be included in
mod_vhost_alias.c - enabling it with a new directive (SetVirtualDocumentRoot) is
a great idea, so it does not mess with document_root when not expected to, but
can be told to do so.

I understand the Apache developers resistance to including this functionality as
document_root should not be relied upon to give the correct path if
mod_alias/mod_rewrite etc have done some funky magic. However, the fact remains
that there's a LOT of scripts out there which do rely on it, and for most users,
 the behaviour they expect (the Right Thing) is for document_root to be set to
whatever document_root was decided upon by mod_vhost_alias.c.

The patch didn't work for me, for Apache 2.2.2 - looks like
vhost_alias_interpolate has been changed since you wrote your patch.  I'll
manually apply the changes to that hunk and regenerate the patch and attach it
shortly.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message