httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 39059] - patch to compile apr-1.2.2 on SkyOS
Date Sun, 02 Apr 2006 23:07:20 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39059>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39059


maxb@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO




------- Additional Comments From maxb@apache.org  2006-04-03 00:07 -------
Marking NEEDINFO.

Peter, please supply new patches which:

* Do not contain spurious whitespace changes. This is very important, as it
makes things very hard to review when the effective changes are concealed in a
mass of irrelevancies.

* Use the method I described on IRC to deal with mkfifo. Ask for clarification
if what I said is not sufficiently detailed for you:

[08/03/2006 15:37] <maxb> Darknesss: add an autoconf test (if you know autoconf)
checking for the function, and then use #ifndef HAVE_MKFIFO return APR_ENOTIMPL;
#endif in pipe.c
[08/03/2006 15:37] <Darknesss> I don't know autoconf...
[08/03/2006 15:39] <maxb> Just adding the following line somewhere in
configure.in, and rerunning ./buildconf, should work:
[08/03/2006 15:39] <maxb> AC_CHECK_FUNCS(mkfifo)
[08/03/2006 15:42] <Darknesss> ok, but what will be the result?
[08/03/2006 15:43] <Darknesss> will it just stop the script or leave out that code?
[08/03/2006 15:44] <chipig> leave out that code
[08/03/2006 15:44] <Darknesss> ok, sounds good :)

* Do not simply switch the order of includes, or remove the declaration of
apr_pstrcatv, since these changes are only concealing the underlying problems,
not solving them. If you would like help trying to diagnose the underlying
problems, then please post to dev@apr.a.o, or try to catch someone interested on
#apr.


Thanks,
Max.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message