httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 38524] - mod_proxy(_http) does not send keep-alive headers
Date Thu, 09 Feb 2006 13:26:03 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38524>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38524





------- Additional Comments From rpluem@apache.org  2006-02-09 14:26 -------
(In reply to comment #5)
> I really should RTFM of patch and diff, so line numbers and order of fileargs 
> wouldn't be a problem ...

I should have looked at the patched version :-).

> 
> 2 things I'm wondering as code novice about: does the copied table get freed and

Yes, because the space is allocated from a memory pool and this pool is cleaned
after the end of the request.

> wouldn't it be better to just save the removed headers ? (P.S: patch isnt't in
> productive environment yet, so we don't know of possible side-effects)

In principle yes, especially if the other headers are large. I have to take a
look into it whether the extra effort of doing so is justified, because several
headers are removed by ap_proxy_clear_connection and it adds some work to save
them and merge them back in. The full copy approach has a simpler logic and if
possible I like to keep things simple :-)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message