httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 37791] - SEGV if the client is connection plain to a SSL enabled port
Date Sat, 28 Jan 2006 00:17:37 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=37791>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37791





------- Additional Comments From rpluem@apache.org  2006-01-28 01:17 -------
(In reply to comment #4)
> 
> if (!(sc->enabled && sslconn && (ssl = sslconn->ssl)))
>    should become
> if ( !sc->enabled || !sslconn || (ssl != sslconn->ssl) )
> 
> Right ?

No.

1. Your version is nearly the same as above because

!(sc->enabled && sslconn && (ssl = sslconn->ssl))  is equal to

!sc->enabled || !sslconn || !(ssl == sslconn->ssl)

keep in mind that 

ssl = sslconn->ssl

and

ssl == sslconn->ssl

are different things. So the original condition becomes true if sslconn->ssl is
equal to NULL which is only checked if sslconn is different from NULL.
But I need to check on the trunk where the current condition is somewhat
different and maybe also wrong. So thanks for the pointer.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message