httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 37100] - SEGV in mod_proxy_ajp
Date Mon, 17 Oct 2005 18:45:07 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=37100>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37100





------- Additional Comments From rpluem@apache.org  2005-10-17 20:45 -------
(In reply to comment #5)
> Passing the brigade for each block is fine; sending an explicit FLUSH bucket
> after each block is not generally a good idea; letting the core output filter
> flush as necessary is better.

Yes, I know that this is not optimal. The idea of adding the flush bucket is
born from the following reason:

If someone on Tomcat flushes the outputstream of the application intentionally,
he wants to sent the data to the client immediately (for whatever reason). If I
do not sent a flush bucket then it can happen that this flushing on Tomcat side
does not work as expected as httpd queues up the data that should be sent to the
client immediately. The current AJP protocol has no field to indicate the
flushing (maybe an idea for AJP/1.4). But that flushing thing here is a critical
tradeoff. So maybe we should keep it configurable. What about adding a field
named flush to the proxy_worker struct and add the flush bucket only if it is
set? I am also fine with setting flush to false as default value, as this may be
the more useful default setting.

> 
> Checking for conn->aborted somewhere in this loop is a good idea also; that will
> be set when the client aborts the connection.  (otherwise the proxy will
> continue passing brigades pointlessly)

Sorry for being confused. Do you mean my check for conn->aborted is a good thing
or that it should be done?



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message