httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 36564] - make mod_ldap really universal
Date Thu, 08 Sep 2005 20:57:20 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=36564>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=36564





------- Additional Comments From ondrej@sury.org  2005-09-08 22:57 -------
You're right that it's pure cosmetic issue, I am merely talking about these lines:

util_ldap.c:1057 ldc->reason = "ldap_search_ext_s() for user failed with server
down";
util_ldap.c:1064 ldc->reason = "ldap_search_ext_s() for user failed";
util_ldap.c:1076 ldc->reason = "User not found";
util_ldap.c:1078 ldc->reason = "User is not unique (search found two or more
matches)";

Maybe simple replace user to entry will do the trick? (I think snprintf warnings
are overkill :-)

I thought about:
renaming util_ldap_cache_getuserdn to util_ldap_cache_find, replacing user to
entry and creating:

LDAP_DECLARE(int) util_ldap_cache_userdn(request_rec *r, 
util_ldap_connection_t *ldc, const char *url, const char *basedn, 
int scope, char **attrs, const char *filter, const char **binddn,
const char ***retvals)

{
  return util_ldap_cache_find(r, ldc, url, basedn, scope, attrs, 
   filter, binddn, retvals);
}

***
In fact it's just my feeling doing something wrong when using getuserdn, so I
would welcome to clean it a bit, but I would not protest if you just close it as
  WONTFIX bug.

Ondrej

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message