httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 28376] - log overflows with a long request
Date Thu, 24 Feb 2005 17:46:06 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=28376>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28376


jorton@redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From jorton@redhat.com  2005-02-24 18:46 -------
As per comments above this is fixed in current releases.

I don't agree with either of the changes in comment 2:

-            if (n < bytes_handled + len) {
+            if (n <= bytes_handled + len) {

this means that exactly N bytes cannot be stored in the buffer, only N - 1; why
is that necessary?

-                    *read = n;
+                    *read = n-1;
                     /* ensure this string is terminated */
                     (*s)[n-1] = '\0';

since *read is suppoed to be set to the total length of the string *including*
the NUL terminator, that isn't correct either.

I'm going to mark this closed and suggest opening new a new issue for a new bug.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message