httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 33490] - APR does not compile with Borland C++
Date Sat, 12 Feb 2005 20:08:42 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=33490>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33490





------- Additional Comments From carnold@apache.org  2005-02-12 21:08 -------
The only explicit place that SIGUSR1 and SIGUSR2 are used in the code base is in threadproc/unix/
signals.c which is not compiled in Windows builds.  Eliminating both those constants from
apr_private.h 
should have no ill effects.  Actually, of all the SIG defines only SIGKILL is needed.  It
is used as a 
parameter to apr_proc_kill in memory/unix/apr_pools.c as the return value for the processes
killed in 
memory pool destruction.  SIGTERM is defined in signal.h for both Microsoft and Borland.

Elminating the #include <ws2tcpip.h> around line 208 in apr.hw does not obviously affect
Microsoft 
builds with VC6. however it is not clear what other effects it may have.  Removing it might
break WinCE 
or something.  Would have to research why it was put there in the first place.

You would not be able to fix the _malloc_dbg issue in apr_private.h since _CRT_BLOCK is defined
in 
inclusions of crtdbg.h which is included after apr_private.h.  _malloc_dbg is mapped to malloc
on non-
debug builds.  I assume that its use here is to cause memory allocated here to not be reported
as 
memory leaks in debug builds.  You could introduce some new functions into apr_private (say

apr_win32_invisible_malloc(size_t, const char* file, int line)) whose implementation could
call 
_malloc_dbg for VC and just plain malloc for other compilers.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message