httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 29755] - mod_usertrack should use err_headers_out
Date Mon, 15 Nov 2004 21:04:17 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=29755>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29755


sjm@almamedia.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://ken.coar.org/burrow/i
                   |                            |ndex?entry=511
            Version|2.0.49                      |2.0.52




------- Additional Comments From sjm@almamedia.fi  2004-11-15 22:04 -------
Sigh.

I just checked Apache 2.0.52 source. It should be fixed.
A simple and suitable patch is attached below:

*** mod_usertrack_orig.c        2004-11-15 22:54:20.000000000 +0200
--- mod_usertrack.c     2004-11-15 22:57:57.000000000 +0200
***************
*** 145,151 ****
                                   NULL);
      }
  
!     apr_table_addn(r->headers_out,
                     (dcfg->style == CT_COOKIE2 ? "Set-Cookie2" : "Set-Cookie"),
                     new_cookie);
      apr_table_setn(r->notes, "cookie", apr_pstrdup(r->pool, cookiebuf));   /*
log first time */
--- 145,151 ----
                                   NULL);
      }
  
!     apr_table_addn(r->err_headers_out,
                     (dcfg->style == CT_COOKIE2 ? "Set-Cookie2" : "Set-Cookie"),
                     new_cookie);
      apr_table_setn(r->notes, "cookie", apr_pstrdup(r->pool, cookiebuf));   /*
log first time */
***************
*** 439,445 ****
  
  static void register_hooks(apr_pool_t *p)
  {
!     ap_hook_fixups(spot_cookie,NULL,NULL,APR_HOOK_MIDDLE);
  }
  
  module AP_MODULE_DECLARE_DATA usertrack_module = {
--- 439,450 ----
  
  static void register_hooks(apr_pool_t *p)
  {
!     /* fixup before mod_proxy, so that the proxied url will not
!      *      * escaped accidentally by our fixup.
!      */
!     static const char * const aszSucc[]={ "mod_rewrite.c", "mod_proxy.c",
!                                         "mod_alias.c", NULL };
!     ap_hook_fixups(spot_cookie, NULL, aszSucc, APR_HOOK_FIRST);
  }
  
  module AP_MODULE_DECLARE_DATA usertrack_module = {


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message