httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 32010] New: - small change
Date Mon, 01 Nov 2004 21:52:29 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=32010>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32010

small change

           Summary: small change
           Product: Apache httpd-2.0
           Version: 2.0.52
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Other
         Component: Build
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: evilsnake42@yahoo.fr
                CC: evilsnake42@yahoo.fr


hello, i'm french so sorry for my bad english :(
My code patch concerns Apache httpd-2.0.52, in file main.c at line : 251
in the "usage" function, in the for, strlen is declared in arguments
so as it is a loop, the strlen function is launched each time of the loop.
That's why I think that in order to save time and memory,
it would be more judicious to use strlen before the for instruction
into another unsigned int and using this variable into the for loop.

like that:
// httpd-2.0.52/server/main.c

line249:  unsigned i,j;
line250:  j = strlen(bin);
line251:  for (i = 0; i < j; i++) {
line252:        pad[i] = ' ';
line253:    }

instead of :

line251: for (i = 0; i < strlen(bin); i++) {

Cordially,
evilsnake < evilsnake42@yahoo.fr >

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message