httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 28903] - Hooks to add environment variables to CGI and other scripted content handlers
Date Tue, 11 May 2004 19:47:20 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=28903>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28903

Hooks to add environment variables to CGI and other scripted content handlers





------- Additional Comments From jschneid@netilla.com  2004-05-11 19:47 -------
I provided two hooks because sometimes both ap_add_common_vars and
ap_add_cgi_vars are called, and sometimes only ap_add_common_vars is called, and
I figured it would be more general to have both hooks available.

I'm calling the hooks in ap_add_common_vars and ap_add_cgi_vars because that's
where the variables are set.  Calling them elsewhere seems more error-prone -
you need to find all occurences of ap_add_common_vars or ap_add_cgi_vars, trace
the execution path, and install the hooks right before the variables get used.

Also, I'm passing a pointer to a table because ap_add_common_vars overwrites
whatever is in the subprocess_env table.  I'm not averse to passing the
request_rec as an additional parameter, but the apr_table_t needs to be passed,
too, or it won't work in ap_add_common_vars.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message