httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 28376] - log overflows with a long request
Date Fri, 07 May 2004 07:02:48 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=28376>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28376

log overflows with a long request

turutani@scphys.kyoto-u.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |REOPENED
         Resolution|FIXED                       |



------- Additional Comments From turutani@scphys.kyoto-u.ac.jp  2004-05-07 07:02 -------
Thank you for your fix.
But I think another fixs are necessary.

--- protocol.c.orig     Fri May  7 15:37:03 2004
+++ protocol.c  Fri May  7 15:37:47 2004
@@ -249,7 +249,7 @@
             }

             /* Would this overrun our buffer?  If so, we'll die. */
-            if (n < bytes_handled + len) {
+            if (n <= bytes_handled + len) {
                 *read = bytes_handled;
                 if (*s) {
                     /* ensure this string is terminated */
@@ -387,7 +387,7 @@
             if (c == APR_ASCII_BLANK || c == APR_ASCII_TAB) {
                 /* Do we have enough space? We may be full now. */
                 if (bytes_handled >= n) {
-                    *read = n;
+                    *read = n-1;
                     /* ensure this string is terminated */
                     (*s)[n-1] = '\0';
                     return APR_ENOSPC;
--(end of diffs)--
About previous patch, I think that in the first section the "if-else" section
is not necessary if "len" is not negative.

And I think, while additional string of "HTTP/1.0" is attatched to tail of the 
request field in the logfile if uri is too long and is truncated for logging,  
it is not natural that there are no space between original request recoreded in 
logfile and additional "HTTP/1.0". I propose to change "HTTP/1.0" to " 
HTTP/1.0" in line 604 of httpd-2.0/server/protocol.c rev1.148 (I do not know 
about the side-effects by this change).

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message