httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 27655] New: - PATCH: Update requested events for a descriptor that is already in a poll set
Date Mon, 15 Mar 2004 00:48:13 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=27655>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27655

PATCH: Update requested events for a descriptor that is already in a poll set

           Summary: PATCH: Update requested events for a descriptor that is
                    already in a poll set
           Product: APR
           Version: 0.9.4
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Other
         Component: APR
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: rob@cataclysm.cx


Attached is a patch that adds a function apr_pollset_update(). This
updates the list of requested events for the descriptor in the
underlying implementation for a descriptor that is already in a pollset.

It works well enough, but I'm not happy with it because it requires a
search through the pollset (just as apr_pollset_remove() does). On a
server with hundreds or thousands of descriptors in the set and changing
events often, this might end up being too expensive.

The optimisation that I'd like to do is to maintain a pointer (by index
or explicit) for each descriptor that points to the descriptors'
underlying pollfd structure, and just use this. This would lose the
ability to enter a socket into the set multiple times with different
events, as is currently possible, but would eliminate the search.

The only problem with this is that such a pointer would really belong in
apr_pollfd_t, except that its specific to the poll() implementation, and
that type is not opaque. So I'd appreciate some pointers on how to best
do this.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message