httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 23295] - Escape problem in mod_rewrite [P] action...
Date Fri, 05 Mar 2004 18:33:07 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23295>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23295

Escape problem in mod_rewrite [P] action...

bp@thinkpink.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable
            Summary|Escape probleme in          |Escape problem in
                   |mod_rewrite [P] action...   |mod_rewrite [P] action...



------- Additional Comments From bp@thinkpink.com  2004-03-05 18:33 -------
URI's are unescaped when processing starts but aren't escaped before being passed to the proxy.
 
The query string needs to be escaped in addition to the filename.  Here are my diffs for 2.0.48:

*** new_mod_rewrite.c   Mon Mar  1 10:49:17 2004
--- mod_rewrite.c       Fri Mar  5 10:23:26 2004
***************
*** 1245,1250 ****
--- 1245,1257 ----
                                            "?", r->args, NULL);
              }
  
+             if (rulestatus != ACTION_NOESCAPE && ((skip = is_absolute_uri(r->filename+6))
> 0)) {
+                 r->filename = escape_absolute_uri(r->pool, r->filename, skip+6);
+                 if (r->args != NULL) {
+                     r->args = ap_escape_uri(r->pool, r->args);
+                 }
+             }
+             
              /* now make sure the request gets handled by the proxy handler */
              r->proxyreq = PROXYREQ_REVERSE;
              r->handler  = "proxy-server";

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message