From bugs-return-11736-apmail-httpd-bugs-archive=httpd.apache.org@httpd.apache.org Sun Feb 08 15:58:18 2004 Return-Path: Delivered-To: apmail-httpd-bugs-archive@www.apache.org Received: (qmail 50658 invoked from network); 8 Feb 2004 15:58:18 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 8 Feb 2004 15:58:18 -0000 Received: (qmail 5873 invoked by uid 500); 8 Feb 2004 15:58:12 -0000 Delivered-To: apmail-httpd-bugs-archive@httpd.apache.org Received: (qmail 5654 invoked by uid 500); 8 Feb 2004 15:58:11 -0000 Mailing-List: contact bugs-help@httpd.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Reply-To: "Apache HTTPD Bugs Notification List" Delivered-To: mailing list bugs@httpd.apache.org Received: (qmail 5636 invoked from network); 8 Feb 2004 15:58:10 -0000 Received: from unknown (HELO exchange.sun.com) (192.18.33.10) by daedalus.apache.org with SMTP; 8 Feb 2004 15:58:10 -0000 Received: (qmail 7419 invoked by uid 50); 8 Feb 2004 15:58:31 -0000 Date: 8 Feb 2004 15:58:31 -0000 Message-ID: <20040208155831.7418.qmail@nagoya.betaversion.org> From: bugzilla@apache.org To: bugs@httpd.apache.org Cc: Subject: DO NOT REPLY [Bug 26771] New: - Mod Status Enhancement X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26771 Mod Status Enhancement Summary: Mod Status Enhancement Product: Apache httpd-1.3 Version: 1.3.27 Platform: All OS/Version: All Status: NEW Severity: Enhancement Priority: Other Component: Other mods AssignedTo: bugs@httpd.apache.org ReportedBy: fcartegnie@free.fr Here's a patch that updates the mod_status (untouched since 1998). Closed html tags, now validated html 4.01T, sortable table columns, ergonomics (readability). Some javascript comes from GNU licence v2. Anyones knows how to deal with this ? (right to use ?) diff -u apache_1.3.27/src/modules/standard/mod_status.c apache_1.3.27_perso/src/modules/standard/mod_status.c --- apache_1.3.27/src/modules/standard/mod_status.c 2002-03-13 22:05:34.000000000 +0100 +++ apache_1.3.27_perso/src/modules/standard/mod_status.c 2004-02-08 16:58:05.000000000 +0100 @@ -94,6 +94,8 @@ * extended STATUS is enabled) [George Burgyan/Jim J.] * 10.8.98 Allow for extended status info at runtime (no more STATUS) * [Jim J.] + * 08.2.04 Fixed unclosed tags. Added stylesheet and javascript sorting ability + * on table display. Readability enhancements [Cartegnie Francois] */ #define CORE_PRIVATE @@ -343,10 +345,95 @@ ap_hard_timeout("send status info", r); if (!short_report) { - ap_rputs(DOCTYPE_HTML_3_2 - "\nApache Status\n\n", + ap_rputs(DOCTYPE_HTML_4_0T + "\nApache Status\n", r); - ap_rputs("

Apache Server Status for ", r); + + if (!no_table_report) { + ap_rputs("\n",r); + + + ap_rputs("\n", r); + } + + ap_rputs("\n

Apache Server Status for ", r); ap_rvputs(r, ap_get_server_name(r), "

\n\n", NULL); ap_rvputs(r, "Server Version: ", ap_get_server_version(), "
\n", NULL); @@ -448,7 +535,7 @@ ap_rputs("\n", r); else { ap_rputs("\n", r); - ap_rputs("Scoreboard Key:
\n", r); + ap_rputs("

Scoreboard Key:
\n", r); ap_rputs("\"_\" Waiting for Connection, \n", r); ap_rputs("\"S\" Starting up, \n", r); ap_rputs("\"R\" Reading Request,
\n", r); @@ -457,8 +544,8 @@ ap_rputs("\"D\" DNS Lookup,
\n", r); ap_rputs("\"L\" Logging, \n", r); ap_rputs("\"G\" Gracefully finishing, \n", r); - ap_rputs("\".\" Open slot with no current process

\n", r); - ap_rputs("

\n", r); + ap_rputs("\".\" Open slot with no current process\n", r); + ap_rputs("

\n", r); if (!ap_extended_status) { int j = 0; ap_rputs("PID Key:
\n", r); @@ -482,13 +569,13 @@ if (ap_extended_status) { if (!short_report) { if (no_table_report) - ap_rputs("

Server Details

\n\n", r); + ap_rputs("

Server Details

\n\n

", r); else #ifdef NO_TIMES /* Allow for OS/2 not having CPU stats */ - ap_rputs("

\n\n\n\n", r); + ap_rputs("

\n\n

SrvPIDAccM\nSSReqConnChildSlotClientVHostRequest
\n\n", r); #else - ap_rputs("

\n\n

SrvPIDAccM\nSSReqConnChildSlotClientVHostRequest
\n\n", r); + ap_rputs("

\n\n

SrvPIDAccMCPU\nSSReqConnChildSlotClientVHostRequest
\n\n", r); #endif } @@ -609,53 +696,53 @@ else { /* !no_table_report */ if (score_record.status == SERVER_DEAD) ap_rprintf(r, - "", i, (int) ps_record.generation, (int) conn_lres, my_lres, lres); else ap_rprintf(r, - "", i, (int) ps_record.generation, (int) ps_record.pid, (int) conn_lres, my_lres, lres); switch (score_record.status) { case SERVER_READY: - ap_rputs("", r); break; case SERVER_STARTING: - ap_rputs("", r); break; case SERVER_BUSY_READ: - ap_rputs("", r); break; case SERVER_BUSY_WRITE: - ap_rputs("", r); break; case SERVER_BUSY_KEEPALIVE: - ap_rputs("", r); break; case SERVER_BUSY_LOG: - ap_rputs("", r); break; case SERVER_BUSY_DNS: - ap_rputs("", r); break; case SERVER_DEAD: - ap_rputs("", r); break; case SERVER_GRACEFUL: - ap_rputs("", r); break; default: - ap_rputs("", r); break; } #ifdef NO_TIMES /* Allow for OS/2 not having CPU stats */ - ap_rprintf(r, "\n", #else - ap_rprintf(r, "\n", (score_record.times.tms_utime + score_record.times.tms_stime + score_record.times.tms_cutime + @@ -667,15 +754,15 @@ difftime(nowtime, score_record.last_used), #endif (long) req_time); - ap_rprintf(r, "\n", (float) conn_bytes / KBYTE, (float) my_bytes / MBYTE, (float) bytes / MBYTE); if (score_record.status == SERVER_BUSY_READ) ap_rprintf(r, - "\n\n"); + "\n\n"); else ap_rprintf(r, - "\n\n", + "\n\n", ap_escape_html(r->pool, score_record.client), vhost ? ap_escape_html(r->pool, vhost->server_hostname) : "(unavailable)", @@ -687,33 +774,33 @@ if (!(short_report || no_table_report)) { #ifdef NO_TIMES - ap_rputs("
SrvPIDAccMCPU\nSSReqConnChildSlotClientVHostRequest
%d-%d-%d/%lu/%lu", + "
%d-%d-%d/%lu/%lu
%d-%d%d%d/%lu/%lu", + "
%d-%d%d%d/%lu/%lu_", r); + ap_rputs("_S", r); + ap_rputs("SR", r); + ap_rputs("RW", r); + ap_rputs("WK", r); + ap_rputs("KL", r); + ap_rputs("LD", r); + ap_rputs("D.", r); + ap_rputs(".G", r); + ap_rputs("G?", r); + ap_rputs("?%.0f%ld", + ap_rprintf(r, "\n%.0f%ld%.2f%.0f%ld", + ap_rprintf(r, "\n%.2f%.0f%ld%-1.1f%-2.2f%-2.2f\n", + ap_rprintf(r, "%-1.1f%-2.2f%-2.2f??..reading..
??..reading..
%s%s%s
%s%s%s
\n \ + ap_rputs("

\n \
\ \n \ -\n \ +\n \ +\n \ +\n \ +\n \ +\n \ +\n \ +\n \ +\n \
SrvChild Server number - generation\n \ -
PIDOS process ID\n \ -
AccNumber of accesses this connection / this child / this slot\n \ -
MMode of operation\n \ -
SSSeconds since beginning of most recent request\n \ -
ReqMilliseconds required to process most recent request\n \ -
ConnKilobytes transferred this connection\n \ -
ChildMegabytes transferred this child\n \ -
SlotTotal megabytes transferred this slot\n \ +
SrvChild Server number - generation
PIDOS process ID
AccNumber of accesses this connection / this child / this slot
MMode of operation
SSSeconds since beginning of most recent request
ReqMilliseconds required to process most recent request
ConnKilobytes transferred this connection
ChildMegabytes transferred this child
SlotTotal megabytes transferred this slot
\n", r); #else ap_rputs("\n \
\ \n \ -\n \ +\n \ +\n \ +\n \ +\n \ +\n \ +\n \ +\n \ +\n \ +\n \
SrvChild Server number - generation\n \ -
PIDOS process ID\n \ -
AccNumber of accesses this connection / this child / this slot\n \ -
MMode of operation\n \ -
CPUCPU usage, number of seconds\n \ -
SSSeconds since beginning of most recent request\n \ -
ReqMilliseconds required to process most recent request\n \ -
ConnKilobytes transferred this connection\n \ -
ChildMegabytes transferred this child\n \ -
SlotTotal megabytes transferred this slot\n \ +
SrvChild Server number - generation
PIDOS process ID
AccNumber of accesses this connection / this child / this slot
MMode of operation
CPUCPU usage, number of seconds
SSSeconds since beginning of most recent request
ReqMilliseconds required to process most recent request
ConnKilobytes transferred this connection
ChildMegabytes transferred this child
SlotTotal megabytes transferred this slot
\n", r); #endif } --------------------------------------------------------------------- To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org For additional commands, e-mail: bugs-help@httpd.apache.org