httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 25324] New: - missing declaration for apr_socket_from_file
Date Mon, 08 Dec 2003 14:04:07 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25324>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25324

missing declaration for apr_socket_from_file

           Summary: missing declaration for apr_socket_from_file
           Product: APR
           Version: HEAD
          Platform: Other
               URL: http://marc.theaimsgroup.com/?l=apr-
                    dev&m=107056669225037&w=2
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: Other
         Component: APR
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: geoff@apache.org


this bug was originally reported to apr-dev

http://marc.theaimsgroup.com/?l=apr-dev&m=107056669225037&w=2

httpd-2.1 current does not compile cleanly with -Werror.

cc1: warnings being treated as errors
pollacc.c:67: warning: no previous prototype for `apr_socket_from_file'

anyway, it looks like the function was meant for removal but didn't get
fully blown away.

Index: poll/unix/pollacc.c
===================================================================
RCS file: /home/cvspublic/apr/poll/unix/pollacc.c,v
retrieving revision 1.9
diff -u -r1.9 pollacc.c
--- poll/unix/pollacc.c	17 Nov 2003 00:32:36 -0000	1.9
+++ poll/unix/pollacc.c	4 Dec 2003 19:32:24 -0000
@@ -56,19 +56,3 @@
 #include "apr_arch_networkio.h"
 #include "apr_arch_file_io.h"
 
-
-#if APR_FILES_AS_SOCKETS
-/* I'm not sure if this needs to return an apr_status_t or not, but
- * for right now, we'll leave it this way, and change it later if
- * necessary.
- */
-APR_DECLARE(apr_status_t) apr_socket_from_file(apr_socket_t **newsock,
-                                               apr_file_t *file)
-{
-    (*newsock) = apr_pcalloc(file->pool, sizeof(**newsock));
-    (*newsock)->socketdes = file->filedes;
-    (*newsock)->cntxt = file->pool;
-    (*newsock)->timeout = file->timeout;
-    return APR_SUCCESS;
-}
-#endif

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message