httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 24331] New: - SSLPassPhraseDialog exec: always default port in argv
Date Sun, 02 Nov 2003 10:45:39 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24331>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24331

SSLPassPhraseDialog exec: always default port in argv

           Summary: SSLPassPhraseDialog exec: always default port in argv
           Product: Apache httpd-2.0
           Version: 2.0.47
          Platform: Sun
        OS/Version: Solaris
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: mod_ssl
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: jm@ccn.net


Problem:
When setting up a SSL VHost the SSLPassPhraseDialog exec: binary _always_ gets
the default port 443 in argv.
If there are more SSL VHosts with same IP/Name and different ports in httpd.conf
i got no chance to figure out the correct PassPhrase for this particular Vhost
bacause they all get port 443 in argv.

Possible solution:
In ssl_util.c: ssl_util_vhostid tries to get the port of the actual VHost from
s->port. s->port is always 0 so DEFAULT_HTTPS_PORT is returned. I did some
changes in ssl_util.c so ssl_util_vhostid returs s->addrs->host_port instead of
s->port which works fine for me.

httpd.conf snippet:
<IfDefine SSL>
       SSLPassPhraseDialog exec:/usr/local/bin/get_passphrase
</IfDefine>

Listen 192.168.9.1:444
Listen 192.168.9.1:445
<VirtualHost 192.168.9.1:444>
    ......
    SSLCertificateFile fl1.crt
    SSLCertificateKeyFile fl1.key
    ......
</VirtualHost>
<VirtualHost 192.168.9.1:445>
    ......
    SSLCertificateFile fl2.crt
    SSLCertificateKeyFile fl2.key
    ......
</VirtualHost>

changes in ssl_util.c:
*** ssl_util.c  Sun Nov  2 00:09:01 2003
--- /usr/local/apache-2.0.47/src/httpd-2.0.47/modules/ssl/ssl_util.c  Fri May 16
20:12:19 2003
***************
*** 80,97 ****
      apr_port_t port;
  
      host = s->server_hostname;
!     if (s->addrs->host_port != 0)
!         port = s->addrs->host_port;
      else {
!         if (s->port != 0)
!             port = s->port;
!         else {
!             sc = mySrvConfig(s);
!             if (sc->enabled)
!                 port = DEFAULT_HTTPS_PORT;
!             else
!                 port = DEFAULT_HTTP_PORT;
!         }
      }
      id = apr_psprintf(p, "%s:%lu", host, (unsigned long)port);
      return id;
--- 80,93 ----
      apr_port_t port;
  
      host = s->server_hostname;
!     if (s->port != 0)
!         port = s->port;
      else {
!         sc = mySrvConfig(s);
!         if (sc->enabled)
!             port = DEFAULT_HTTPS_PORT;
!         else
!             port = DEFAULT_HTTP_PORT;
      }
      id = apr_psprintf(p, "%s:%lu", host, (unsigned long)port);
      return id;

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message