httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 23825] New: - Duplicate code? Apache parses config and opens logs twice.
Date Wed, 15 Oct 2003 00:57:51 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23825>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23825

Duplicate code? Apache parses config and opens logs twice.

           Summary: Duplicate code? Apache parses config and opens logs
                    twice.
           Product: Apache httpd-1.3
           Version: 1.3.28
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Other
         Component: core
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: ianc@nidsolutions.com


in http_main.c, around line 5508 (I've made some changes, I don't know what it 
is on virgin source) there's the following code.

    if (ap_standalone) {
        ap_open_logs(server_conf, plog);
        ap_set_version();
        ap_init_modules(pconf, server_conf);
        version_locked++;
        STANDALONE_MAIN(argc, argv);
    }

standalone_main contains the same code before it forks off children

        ap_open_logs(server_conf, plog);
        ap_log_pid(pconf, ap_pid_fname);
        ap_set_version();       /* create our server_version string */
        ap_init_modules(pconf, server_conf);
        version_locked++;       /* no more changes to server_version */

Is this duplicate code? Is this necessary? Thanks.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message