httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 9587] - Wrong icon with FancyIndexing
Date Tue, 15 Jul 2003 07:51:37 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9587>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9587

Wrong icon with FancyIndexing





------- Additional Comments From dpejesh@yahoo.com  2003-07-15 07:51 -------
Commenting out 'if (!(p->icon = find_icon(d, rr, 1)))' breaks the ability to
specify an icon for a directory with an AddIcon directive .  I've walked through
this code a ton of times and the simplest patch i've come up with is...

Index: modules/generators/mod_autoindex.c
===================================================================
RCS file: /home/cvspublic/httpd-2.0/modules/generators/mod_autoindex.c,v
retrieving revision 1.119
diff -u -r1.119 mod_autoindex.c
--- modules/generators/mod_autoindex.c  2 Mar 2003 18:06:16 -0000       1.119
+++ modules/generators/mod_autoindex.c  15 Jul 2003 07:28:50 -0000
@@ -1361,6 +1361,7 @@
             if (autoindex_opts & FOLDERS_FIRST) {
                 p->isdir = 1;
             }
+            rr->filename = ap_make_dirstr_parent (rr->pool, rr->filename);
             if (!(p->icon = find_icon(d, rr, 1))) {
                 p->icon = find_default_icon(d, "^^DIRECTORY^^");
             }

which removes the appended filename added by mod_dir, if any, from rr->filename
which results in find_icon seeing the correct filename.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message