httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 21095] - SSI error
Date Fri, 11 Jul 2003 19:31:32 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21095>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21095

SSI error





------- Additional Comments From jwoolley@apache.org  2003-07-11 19:31 -------
Andre: you win.  I guess I thought continue; went back to the top of the loop and thus 
would not catch the condition on a do{}while rather than a while(){}.  But K&R tells 
me it will work your way.  Good call.  :) 
 
Kevin: the reason is that with mmaping enabled, the entire file is slurped in as one big 
mmap bucket.  with mmap disabled, it actually calls apr_file_read() on the file and 
pulls the data into memory 8000 bytes at a time, one buffer per heap bucket. 
 
+1 to the version of the patch that said: 
 
         if (len == 0) { /* end of pipe? */ 
-            break; 
+            dptr = APR_BUCKET_NEXT(dptr); 
+            continue; 
         } 
 
I believe it safe for production.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message