httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 19675] New: - Performance/code cleanliness nit in proxy_util.c
Date Mon, 05 May 2003 16:16:57 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19675>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19675

Performance/code cleanliness nit in proxy_util.c

           Summary: Performance/code cleanliness nit in proxy_util.c
           Product: Apache httpd-1.3
           Version: 1.3.27
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Other
         Component: mod_proxy
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: martin@snowplow.org


Version 1.126 of proxy_util.c was created to fix bugs 10026 and 11668, and it
does fix them.

However, I feel that the fix introduced is wasteful in that it does a strlen
followed by a ap_pstrcat, when a simple one-character check and one-character
assignment is sufficient.

I'll attach a patch showing the change I propose.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message