httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 18573] - http proxy doesn't handle responses w/o reason phrase
Date Mon, 05 May 2003 14:55:31 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18573>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18573

http proxy doesn't handle responses w/o reason phrase





------- Additional Comments From martin@snowplow.org  2003-05-05 14:55 -------
Actually, since ap_getline trims off trailing whitespace, the remote server
could have sent a perfectly valid response that includes the space after the
status code and then nothing else.  (In fact, this is exactly what many java
servlet containers acting as web servers do)

In this case, not only is apache issuing a spurious warning message (line 739),
but it is taking perfectly RFC-compliant input and failing.  Bad.

In my opinion, version 1.159 of proxy_util.c fixed the bug it claimed to fix
incorrectly - I much prefer a patch similar to the one created for bug 11668
(that bug's for apache 1.3).  The blank space after the numeric status code
which ap_getline stripped needs to be placed back in.  A simple:

    if ('\0' == buffer[12]) buffer[13] = '\0';

before the manipulation of buffer[12] would have been the correct thing to do -
the current mucking about with keepchar does not undo the damage that ap_getline
can do to the status line.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message