httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 16313] - Multiple MMapFile causes Segmentation fault
Date Wed, 22 Jan 2003 23:23:10 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16313>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16313

Multiple MMapFile causes Segmentation fault





------- Additional Comments From drew@damnimp.com  2003-01-22 23:23 -------
Tried the patch...it works just fine.
Out of interest though, instead of (or also with) deleting the section of code 
that calls the APR_RING_REMOVE define, why not just add error-checking into the 
APR_RING_UNSPLICE define with a couple of 'if' statements in apr_ring.h?
Example:

#define APR_RING_UNSPLICE(ep1, epN, link) do {                          \
        if (APR_RING_PREV((ep1), link))                                 \
                APR_RING_NEXT(APR_RING_PREV((ep1), link), link) =       \
                        APR_RING_NEXT((epN), link);                     \
        if (APR_RING_NEXT((epN), link))                                 \
                APR_RING_PREV(APR_RING_NEXT((epN), link), link) =       \
                        APR_RING_PREV((ep1), link);                     \
   } while (0)

I tested this modification with the original mod_file_cache.c and it seems to 
work as well.  Although, truth be told, I'm not entirely sure how to find out 
if it has memory or fd leaks (I program mainly on win32...unix still mystifies 
me at times!)  The only reason I'd suggest this is to keep this same problem 
happening in potential future modules that register a cleanup call for a 
simular list.

Thanks-
Drew

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message