httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 7791] - mod_suexec problem
Date Sun, 26 May 2002 00:56:04 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7791>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7791

mod_suexec problem





------- Additional Comments From colmmacc@redbrick.dcu.ie  2002-05-26 00:56 -------
I'm seeing this bug aswell in 2.036 and CVS. suexec is getting passed args 
ala:

   /path/to/suexec (~)uid gid cmdname argv0 argv1 argv2 

and so on. Previously in 1.3 it was : 

   /path/to/suexec (~)uid gid argv0 argv1 argv2 

and argv0 was assumed to == cmdname. This patch reverts to the previous
behaviour.

Index: os/unix/unixd.c
===================================================================
RCS file: /home/cvspublic/httpd-2.0/os/unix/unixd.c,v
retrieving revision 1.52
diff -u -u -r1.52 unixd.c
--- os/unix/unixd.c     17 May 2002 11:33:10 -0000      1.52
+++ os/unix/unixd.c     26 May 2002 00:47:29 -0000
@@ -350,16 +350,16 @@
            }
     }
     /* allocate space for 4 new args, the input args, and a null terminator */
-    newargs = apr_palloc(p, sizeof(char *) * (i + 5));
+    newargs = apr_palloc(p, sizeof(char *) * (i + 4));
     newprogname = SUEXEC_BIN;
     newargs[0] = SUEXEC_BIN;
     newargs[1] = execuser;
     newargs[2] = execgroup;
     newargs[3] = apr_pstrdup(p, progname);

-    i = 0;
+    i = 1;
     do {
-        newargs[i + 4] = args[i];
+        newargs[i + 3] = args[i];
     } while (args[i++]);

     return apr_proc_create(newproc, newprogname, newargs, env, attr, p);

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message