Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of margol@beamartyr.net designates
 85.195.98.136 as permitted sender)
Message-ID: <5444E698.70106@beamartyr.net>
Date: Mon, 20 Oct 2014 13:40:24 +0300
From: Issac Goldstand <margol@beamartyr.net>
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64;
 rv:31.0) Gecko/20100101 Thunderbird/31.1.2
MIME-Version: 1.0
To: apreq-dev@httpd.apache.org
Subject: Re: [PATCH] Restore Windows (and NeXT and NetWare etc) build of test
 suite following revision 1124400
References: 
 <CADED=K5=afgJi-YQwXiOfFfWKXac5q+5YGhzFpyFUiLFEBBFYA@mail.gmail.com>
 <CADED=K4W1E8eperxHzPH8upHzv_gapN-6Xgoo7QQym9+ojOBPQ@mail.gmail.com>
In-Reply-To: 
 <CADED=K4W1E8eperxHzPH8upHzv_gapN-6Xgoo7QQym9+ojOBPQ@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

Fixed in r1633096

Thank you!

On 13/07/2014 16:35, Steve Hay wrote:
> On 21 March 2014 22:17, Steve Hay <steve.m.hay@googlemail.com> wrote:
>> Testing a mod_perl & libapreq build on Windows I have come across a
>> problem introduced into the current SVN trunk of libapreq by revision
>> 1124400.
>>
>> The attached patch fixes the problem for me on Windows, and hopefully
>> for any NeXT and NetWare users out there too, but it seems I don't
>> have commit access to apreq. Please could somebody apply this (and
>> even test the non-Windows cases first if possible too)?
> 
> The original patch fixed the build on Windows, but not quite as
> intended: It used nothing for the definition of AT_INLINE, instead of
> using __inline as I had intended. (The main thing is not to use inline
> (or __inline__), which MS VC++ doesn't understand.)
> 
> The attached patch corrects that.
>