httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Hay" <Steve...@planit.com>
Subject RE: Volunteer for RMing 2.12?
Date Thu, 05 Mar 2009 16:46:12 GMT
Joe Schaefer wrote:
> ----- Original Message ----
> 
>> From: Steve Hay <SteveHay@planit.com>
>> To: Joe Schaefer <joe_schaefer@yahoo.com>; apreq-dev@httpd.apache.org
>> Sent: Thursday, March 5, 2009 8:52:58 AM
>> Subject: RE: Volunteer for RMing 2.12?
>> 
>> Steve Hay wrote:
>>> Joe Schaefer wrote:
>>>> ----- Original Message ----
>>>>> From: Joe Schaefer
>>>>> To: Steve Hay ; apreq-dev@httpd.apache.org
>>>>> Sent: Thursday, March 5, 2009 6:46:33 AM
>>>>> Subject: Re: Volunteer for RMing 2.12?
>>>>> 
>>>>> 
>>>>> ----- Original Message ----
>>>>> 
>>>>>> From: Steve Hay
>>>>>> To: Joe Schaefer ; apreq-dev@httpd.apache.org
>>>>>> Sent: Thursday, March 5, 2009 4:03:40 AM
>>>>>> Subject: RE: Volunteer for RMing 2.12?
>>>>>> 
>>>>>> Joe Schaefer wrote:
>>>>>>> I cut a tarball from trunk that Randy
>>>>>>> and company can test out on Win32:
>>>>>>> 
>>>>>>> http://people.apache.org/~joes/libapreq2-trunk.tar.gz
>>>>>>> 
>>>>>>> Assuming it gets tested and generally agreed
>>>>>>> to be worth releasing, is anyone willing to
>>>>>>> do the honors and volunteer for RM duties?
>>>>>> 
>>>>>> Still doesn't build on Win32:
>>>>>> 
>>>>>> [...]
>>>>>> cl.exe /Fo"C:\Temp\LIBAPR~1.12\win32\libs\handle.obj" /nologo /MD
>>>>>> /W3 /O2 /D "WIN32" /D "NDEBUG" /D "_WINDOWS" /D "_MBCS" /D
>>>>>> "_USRDLL" /D "APREQ_DECLARE_EXPORT" /I"C:\apache2.2\include"
>>>>>> /I"C:\Temp\LIBAPR~1.12\include"
>>>>>> /I"C:\Temp\LIBAPR~1.12\module\apache2" /YX /FD /c
>>>>>> C:\Temp\LIBAPR~1.12\module\apache2\handle.c
>>>>>> cl : Command line warning D9002 : ignoring unknown option '/YX'
>>>>>> handle.c
>>>>>> c:\temp\libapreq2-2.12\module\apache2\apreq_module_apache2.h(149)
>>>>>>> error C2059: syntax error : '('
>>>>>> NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual
>>>>>> Studio 8\VC\bin\cl.exe"' : return code '0x2'
>>>>>> Stop.
>>>>>> NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual
>>>>>> Studio 8\VC\bin\nmake.exe"' : return code '0x2'
>>>>>> Stop.
>>>>>> 
>>>>>> I guess it's tripping up on
>>>>>> http://svn.apache.org/viewvc?view=rev&revision=744417, which
I
>>>>>> assume was an attempt to do something similar to my hack in
>>>>>> http://marc.info/?l=apreq-dev&m=123391925319834&w=2
>>>>> 
>>>>> Yeah, that looks like the problem this time.  Any idea what those
>>>>> macros now expand to on your machine?  (I'm pretty sure the reason
>>>>> your hack doesn't work is because of the _stdcall thingy).
>>>> 
>>>> 
>>>> Steve, I just uploaded a new tarball (same url) with the latest fix
>>>> attempt. Any improvements this time?
>>> 
>>> Sadly not: still the same error.
>>> 
>>> Here's the pre-processor's output this time:
>>> 
>>> __declspec(dllexport) apreq_handle_t * __stdcall
>>> apreq_handle_apache2(request_rec *r);
>>> 
>>> typedef apreq_handle_t * __stdcall (apr_OFN_apreq_handle_apache2_t)
>>> (request_rec *r);
>> 
>> Hmm. I'm not hot on this syntax, but it compiles if you move the
>> __stdcall *inside* the first set of parentheses:
>> 
>> typedef apreq_handle_t *(__stdcall apr_OFN_apreq_handle_apache2_t)
>> (request_rec *r);
> 
> Interesting.  We may need to just hand-code it this way for WIN32.
> The next question is, do the tests compile and pass?

Yes, using the attached patch everything builds okay and all the tests
pass.

Mime
View raw message