Return-Path: Delivered-To: apmail-httpd-apreq-dev-archive@www.apache.org Received: (qmail 81716 invoked from network); 16 Dec 2008 14:15:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 Dec 2008 14:15:09 -0000 Received: (qmail 81171 invoked by uid 500); 16 Dec 2008 14:15:22 -0000 Delivered-To: apmail-httpd-apreq-dev-archive@httpd.apache.org Received: (qmail 81144 invoked by uid 500); 16 Dec 2008 14:15:22 -0000 Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list apreq-dev@httpd.apache.org Received: (qmail 81135 invoked by uid 99); 16 Dec 2008 14:15:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Dec 2008 06:15:22 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of koziarski@gmail.com designates 209.85.200.173 as permitted sender) Received: from [209.85.200.173] (HELO wf-out-1314.google.com) (209.85.200.173) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Dec 2008 14:15:00 +0000 Received: by wf-out-1314.google.com with SMTP id 24so2984349wfg.15 for ; Tue, 16 Dec 2008 06:14:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=dUmcctvdoTqKrv49LpD/R6+szf6av7fuua7Dg1lU9hg=; b=G1E/Ajl7gMKuk1m+AfED0GGJ6QkITV+6s+ws21khcE+RtW1jpdZVUElAaQenZ0CshU QPtICpswEddJYuMr11PQFq+aTEb2q/+vhIFtKFI/WvMQ6H9uLfPKPcc3M4WkpTME9j8E vj7cRbnsjIVK9fDpysJalKqKguCq7iLHYpqRM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=LjkUfz3XkJJIvtwK6rqzIR3QhlVUAuRIMco4n2P2cGSXeItRVD6Yh5ZubG2Su2YurN gFlye32geBVRJStkdAM5LtjEQ6yBy9gviJWfwxrsOJFqmMBe+KhptGw137DC4zXz9Y1U ojT5cJtcLguiIARGFyZinvb8Tjs5AvNM69pVQ= Received: by 10.142.14.20 with SMTP id 20mr3323154wfn.79.1229436880385; Tue, 16 Dec 2008 06:14:40 -0800 (PST) Received: by 10.142.226.20 with HTTP; Tue, 16 Dec 2008 06:14:40 -0800 (PST) Message-ID: Date: Tue, 16 Dec 2008 15:14:40 +0100 From: "Michael Koziarski" Sender: koziarski@gmail.com To: "Philip M. Gollucci" Subject: Re: Questions about apreq_params Cc: apreq-dev@httpd.apache.org In-Reply-To: <4946E525.1040207@p6m7g8.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4946CF21.6040009@p6m7g8.com> <4946DA1F.1080007@p6m7g8.com> <4946DE39.4030108@p6m7g8.com> <4946E525.1040207@p6m7g8.com> X-Google-Sender-Auth: 8bd212e196d49f4a X-Virus-Checked: Checked by ClamAV on apache.org On Tue, Dec 16, 2008 at 12:15 AM, Philip M. Gollucci wrote: > Michael Koziarski wrote: >>> >>> It should definitely not be deprecated. Its kind of 'core' to the >>> module. >> >> But unless I'm mistaken, it'll just silently fail in these situations >> with malformed bodies? What would be the suggested action in that >> situation? something like this? > > I think step one is to come up with a test that reproduces the break in the > docs. Commit it as 'skip', then fix the code so the test passes ensuring we > don't break anything else in the process. OK, I'm about to spend a week travelling but I've added this to my TODO list. I'm far from an expert with this stuff so apologies if it takes me a little while. At the very least I'll get us a request body which repeatedly triggers it. > -- > ------------------------------------------------------------------------ > Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 > Consultant - P6M7G8 Inc. http://p6m7g8.net > Senior System Admin - RideCharge, Inc. http://ridecharge.com > 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C > > Work like you don't need the money, > love like you'll never get hurt, > and dance like nobody's watching. > -- Cheers Koz