Return-Path: Delivered-To: apmail-httpd-apreq-dev-archive@www.apache.org Received: (qmail 43105 invoked from network); 25 Apr 2008 05:44:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 25 Apr 2008 05:44:35 -0000 Received: (qmail 82645 invoked by uid 500); 25 Apr 2008 05:44:36 -0000 Delivered-To: apmail-httpd-apreq-dev-archive@httpd.apache.org Received: (qmail 82629 invoked by uid 500); 25 Apr 2008 05:44:36 -0000 Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list apreq-dev@httpd.apache.org Received: (qmail 82618 invoked by uid 99); 25 Apr 2008 05:44:36 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Apr 2008 22:44:36 -0700 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [213.191.128.81] (HELO mxout2.iskon.hr) (213.191.128.81) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 25 Apr 2008 05:43:50 +0000 Received: (qmail 2242 invoked from network); 25 Apr 2008 07:44:00 +0200 X-Remote-IP: 213.191.142.124 Received: from unknown (HELO mx.iskon.hr) (213.191.142.124) by mxout2.iskon.hr with SMTP; 25 Apr 2008 07:44:00 +0200 Received: (qmail 22018 invoked from network); 25 Apr 2008 07:44:00 +0200 X-AVScan: ClamAV X-Remote-IP: 89.164.14.170 Received: from 14-170.dsl.iskon.hr (HELO ?192.168.0.10?) (89.164.14.170) by mx.iskon.hr with SMTP; 25 Apr 2008 07:44:00 +0200 Message-ID: <48116F9F.2040609@apache.org> Date: Fri, 25 Apr 2008 07:43:59 +0200 From: Mladen Turk User-Agent: Thunderbird 1.5.0.12 (X11/20071129) MIME-Version: 1.0 To: apreq-dev@httpd.apache.org Subject: Re: [PATCH] Some windows build enhancements References: <4810A66B.5090606@apache.org> <4810EDDF.3080304@p6m7g8.com> In-Reply-To: <4810EDDF.3080304@p6m7g8.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Philip M. Gollucci wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Mladen Turk wrote: > | Hi, > | > | libapreq is missing .rc file, so here is a standard ASF one. > | Also, added APREQ_DECLARE_EXPORT/APREQ_DECLARE_STATIC > | in the same way as APR declares so that dllexport/dllimport > | get correctly handled. > Hi Mladen, > > Thanks for your work on this. In the future, please submit patches > piece wise. > > Committed to trunk: 651366, 651374, 651381, 651385, 651388 > > backported to v2_10 branch: 651399. > ACK. There was one small typo and it seems I have the karma for commits, so I've fixed it directly. I suppose the fix has to go to the 2.10 branch as well. Regards -- (TM)