Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (herse.apache.org: local policy)
Message-ID: <462B442C.40400@beamartyr.net>
Date: Sun, 22 Apr 2007 14:17:00 +0300
From: Issac Goldstand <margol@beamartyr.net>
User-Agent: Thunderbird 1.5.0.10 (Windows/20070221)
MIME-Version: 1.0
To: apreq-dev@httpd.apache.org
Subject: Re: Fixed: Truncated uploads in mod_perl 1 from FF2.0/Win
References: <200704091818.47390.adamn@wirespring.com>
	<87tzvh52m9.fsf@gemini.sunstarsys.com> <87bqhlnlkr.fsf@gemini.sunstarsys.com>
 <46271C7D.2060708@beamartyr.net>
In-Reply-To: <46271C7D.2060708@beamartyr.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Following up on this, I'd like to take mod_perl's RELEASE file, make it 
fit our needs properly (I'll want people's input on this) and stick it 
into trunk for future reference.  Any objections?

  Issac

Issac Goldstand wrote:
> Joe Schaefer wrote:
>   
>> Joe Schaefer <joe+gmane@sunstarsys.com> writes:
>>
>>     
>>> Right, since it's the start of a boundary.  I think the best way
>>> to fix this is to do what php does and add a loop into fill_buffer
>>> so it completely fills the buffer instead of doing a single read.
>>> Php uses our multipart code for handling uploads, and that's probably
>>> why they haven't seen this bug crop up.
>>>       
>> Issac, are you interested in volunteering to be release manager
>> for a libapreq1 maintenance release?  Looks like we need to do that,
>> but I personally have no interest in championing it through myself.
>>     
>
> Sure.  I have some time now.  To be candid, I haven't RM-ed inside an
> ASF project yet, so I could probably use a quick checklist from you or
> Phillip.
>
>   
>> In the meantime I'll commit my patch unless someone thinks 
>> there's a better solution available.
>>     
>
> I'm +1 on the patch
>
>   Issac
>