httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Issac Goldstand <mar...@beamartyr.net>
Subject Re: Fixed: Truncated uploads in mod_perl 1 from FF2.0/Win
Date Sun, 22 Apr 2007 14:02:05 GMT
I just noticed that Stas actually did this in the latest 1.x branch, but 
it's not in 2.x.  I'll modify his instructions and add to trunk.

  Issac

Issac Goldstand wrote:
> Following up on this, I'd like to take mod_perl's RELEASE file, make 
> it fit our needs properly (I'll want people's input on this) and stick 
> it into trunk for future reference.  Any objections?
>
>  Issac
>
> Issac Goldstand wrote:
>> Joe Schaefer wrote:
>>  
>>> Joe Schaefer <joe+gmane@sunstarsys.com> writes:
>>>
>>>    
>>>> Right, since it's the start of a boundary.  I think the best way
>>>> to fix this is to do what php does and add a loop into fill_buffer
>>>> so it completely fills the buffer instead of doing a single read.
>>>> Php uses our multipart code for handling uploads, and that's probably
>>>> why they haven't seen this bug crop up.
>>>>       
>>> Issac, are you interested in volunteering to be release manager
>>> for a libapreq1 maintenance release?  Looks like we need to do that,
>>> but I personally have no interest in championing it through myself.
>>>     
>>
>> Sure.  I have some time now.  To be candid, I haven't RM-ed inside an
>> ASF project yet, so I could probably use a quick checklist from you or
>> Phillip.
>>
>>  
>>> In the meantime I'll commit my patch unless someone thinks there's a 
>>> better solution available.
>>>     
>>
>> I'm +1 on the patch
>>
>>   Issac
>>   

Mime
View raw message