Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (herse.apache.org: local policy)
Message-ID: <45602EBF.8080602@p6m7g8.com>
Date: Sun, 19 Nov 2006 02:15:27 -0800
From: "Philip M. Gollucci" <pgollucci@p6m7g8.com>
Organization: P6M7G8 Consulting
User-Agent: Thunderbird 1.5 (X11/20060317)
MIME-Version: 1.0
To: apreq-dev@httpd.apache.org
Subject: Re: memory leaking on POST
References: <5b3fa8f0611122201ve28c458n9fba67d6a9c313d9@mail.gmail.com>
	<87wt5zev7w.fsf@gemini.sunstarsys.com>
	<5b3fa8f0611122238n48754012kb7924b98db45e9bc@mail.gmail.com>
	<87psbressv.fsf@gemini.sunstarsys.com>
 <4558BC0A.4060605@p6m7g8.com>	<87mz6vazln.fsf@gemini.sunstarsys.com>
	<5b3fa8f0611131222n28abd8dah90534967b3a0d458@mail.gmail.com>
 <87r6w5wcfe.fsf@gemini.sunstarsys.com>
In-Reply-To: <87r6w5wcfe.fsf@gemini.sunstarsys.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Joe Schaefer wrote:
> "Brian McQueen" <mcqueenorama@gmail.com> writes:
> 
>> What bucket type is SPOOL?  I don't see it as a real bucket type.  I'd
>> like to try out the patch here, but I can't duplicate it because I
>> don't know what a spool bucket is.
> 
> See if this patch to library/util.c solves your leak problem.
> It compiles, but it's largely untested:
> 
> Index: library/util.c
Joe, I say +1 to both trunk and branches/v2_09 --

It passes all the tests with worker and prefork mpms in a variety of 
perl / httpd / mod_perl combinations on freebsd.

I've also had it live on a low volume ithread enabled mp2 production site.

I'm not exactly sure how we would specifically test its not leaking,
but maybe we could use/tweak module/t/c-modules/apreq_upload_test.


-- 
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F  6A47 D55A 7172 A799 97F

I never had a dream come true
'Til the day that I found you.
Even though I pretend that I've moved on
You'll always be my baby.
I never found the words to say
You're the one I think about each day
And I know no matter where life takes me to
A part of me will always be...
A part of me will always be with you.