httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip M. Gollucci" <pgollu...@p6m7g8.com>
Subject Re: memory leaking on POST
Date Wed, 15 Nov 2006 21:55:37 GMT
Joe Schaefer wrote:
> "Brian McQueen" <mcqueenorama@gmail.com> writes:
> 
>> I'll test it out
> 
> Don't bother, I'm pretty sure apreq's behavior is unacceptable
> with that patch.  We call apreq_brigade_fwrite way too many
> times internally to be able to afford to leak a brigade struct
> on each invocation.
> 
> I'll try to commit a proper patch to trunk soonish.  I'm glad
> you found a solution that seems to be working for you, but I'm
> also more than a little skeptical that apreq is working correctly
> if you are simply deleting the original buckets passed into 
> apreq_brigade_fwrite.
> 
This is important enough I'd hold 2.09 off for it.


-- 
------------------------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F  6A47 D55A 7172 A799 97F

When I call your name, Girl, it starts to flame
Burning in my heart, Tearing it all apart..
No matter how I try My love I cannot hide....

Mime
View raw message