Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (asf.osuosl.org: local policy)
Mime-Version: 1.0 (Apple Message framework v746.2)
In-Reply-To: <87slqm4yix.fsf@gemini.sunstarsys.com>
References: <378FE226-A5C6-4D7A-B38F-2F66858B96C8@2xlp.com>
 <E56F4D3F-7F4C-4628-B60B-82783E682FBF@2xlp.com>
 <87slqm4yix.fsf@gemini.sunstarsys.com>
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <7555DA56-4CE5-497A-80FA-75BA63D96B22@2xlp.com>
Content-Transfer-Encoding: 7bit
From: Jonathan Vanasco <jon@2xlp.com>
Subject: Re: POST_MAX
Date: Mon, 13 Feb 2006 19:43:51 -0500
To: apreq-dev@httpd.apache.org


oh so it isn't even built like that already.

i can't figure out how APR handles /stores errors.  i spent far too  
much time this weekend going over the svn head, but don't know nearly  
enough C or any xs to make much of any sense of it

personally though, i'd love to see a way to check for errors ( or  
status ) - that works like either of the below - so  i'm going to  
wishlist them now.  and everyone can say its a bad idea or 'its a  
good idea, here's how to patch it', as i can't figure it out.

1 - a version of the perl glue ( and whatever else ) for the  
xxx_status functions that either
	returns the error code instead of the error message
	returns a tuple of code/message ie: [ 'OVERLIMIT','The POST param  
exceeds the configured limit']
2 - something that only returns errors or lets one probe for a  
specific error.( the former would be better, but i think the latter  
might be easier to code)
	ie:
		if ( my $error = $apr->body_errors() )
		{
			if ( $error == 'OVERLIMIT' ){}
		}
	or
		if ( $apr->body_errors() )
		{
			if (  $apr->has_error('OVERLIMIT')  ){}
		}

as-is, things seem awkward because body_status, args_status are the  
method of catching an error - but also seem to return non-error text.


On Feb 13, 2006, at 6:41 PM, Joe Schaefer wrote:

> Jonathan Vanasco <apreq-dev-list@2xlp.com> writes:
>
>> Anyone?  This is killing me.
>>
>> The only thing I've been able to figure out is this:
>>
>> 	my  $error = $apacheRequest->body_status();
>> 	if ( $error eq 'Exceeds configured maximum limit' )
>
> That looks ok to me for now; but what we really need to do
> is export the constant in Error.xs so you can write
>
>    if ($error == APR::Request::Error::OVERLIMIT)
>
> -- 
> Joe Schaefer
>