httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject Re: Apache2::Cookies - getting all names
Date Wed, 28 Dec 2005 19:48:23 GMT
"Philip M. Gollucci" <pgollucci@p6m7g8.com> writes:

> Index: Cookie.pm
> ===================================================================
> --- Cookie.pm   (revision 359541)
> +++ Cookie.pm   (working copy)
> @@ -40,7 +40,7 @@
>       my $jar = $req->jar or return;
>       $jar->cookie_class(__PACKAGE__);
>       return $jar->get(shift) if @_;
> -    return wantarray ? %$jar : $jar;
> +    return wantarray ? keys %$jar : $jar;
>   }
>
> I'm betting the code change is what we want here.

-1.  We need to fix cookies(), not fetch().  Patch cookies()
so it actually works as documented.

-- 
Joe Schaefer


Mime
View raw message