Return-Path: Delivered-To: apmail-httpd-apreq-dev-archive@www.apache.org Received: (qmail 46934 invoked from network); 11 Oct 2005 18:00:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 11 Oct 2005 18:00:22 -0000 Received: (qmail 30055 invoked by uid 500); 11 Oct 2005 18:00:22 -0000 Delivered-To: apmail-httpd-apreq-dev-archive@httpd.apache.org Received: (qmail 30007 invoked by uid 500); 11 Oct 2005 18:00:21 -0000 Mailing-List: contact apreq-dev-help@httpd.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list apreq-dev@httpd.apache.org Received: (qmail 29996 invoked by uid 99); 11 Oct 2005 18:00:21 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Oct 2005 11:00:21 -0700 X-ASF-Spam-Status: No, hits=1.4 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: 213.243.153.37 is neither permitted nor denied by domain of vskytta@gmail.com) Received: from [213.243.153.37] (HELO smtp1.pp.htv.fi) (213.243.153.37) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Oct 2005 11:00:23 -0700 Received: from [192.168.2.4] (cs168006.pp.htv.fi [213.243.168.6]) by smtp1.pp.htv.fi (Postfix) with ESMTP id 079AB7FC9B for ; Tue, 11 Oct 2005 20:59:58 +0300 (EEST) Subject: Missing cast in apreq_escape() From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: apreq-dev@httpd.apache.org Content-Type: multipart/mixed; boundary="=-iBwpH1LaIH4wMkzSKHUb" Date: Tue, 11 Oct 2005 20:59:57 +0300 Message-Id: <1129053597.16732.8.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --=-iBwpH1LaIH4wMkzSKHUb Content-Type: text/plain Content-Transfer-Encoding: 7bit https://bugzilla.redhat.com/170401 Dirk Nehring pointed out a missing cast in apreq_escape() and submitted a patch, see attachment. This appears to bite when using a C++ compiler with apreq_util.h. --=-iBwpH1LaIH4wMkzSKHUb Content-Disposition: attachment; filename=cast.patch Content-Type: text/x-patch; name=cast.patch; charset=UTF-8 Content-Transfer-Encoding: 7bit Index: include/apreq_util.h =================================================================== --- include/apreq_util.h (revision 312921) +++ include/apreq_util.h (working copy) @@ -208,7 +208,7 @@ if (src == NULL) return NULL; - rv = apr_palloc(p, 3 * slen + 1); + rv = (char *)apr_palloc(p, 3 * slen + 1); apreq_encode(rv, src, slen); return rv; } --=-iBwpH1LaIH4wMkzSKHUb--