httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nikolay Ananiev" <anan...@thegdb.com>
Subject APR::Request::CGI::upload() should be removed?
Date Thu, 08 Sep 2005 15:28:42 GMT
Joe,
after moving upload() to APR::Request, I think
APR::Request::CGI::upload() should be removed. Am I right?
Here's a patch

Index: glue/perl/xsbuilder/APR/Request/CGI/CGI.pm
===================================================================
--- glue/perl/xsbuilder/APR/Request/CGI/CGI.pm (revision 279567)
+++ glue/perl/xsbuilder/APR/Request/CGI/CGI.pm (working copy)
@@ -1,29 +1,3 @@
 require APR::Request;
 use APR::Pool;
 push @ISA, "APR::Request";
-
-sub upload {
-    my $req = shift;
-    my $body = $req->body;
-    $body->param_class("APR::Request::CGI::Upload");
-    if (@_) {
-        return grep {$_->upload} $body->get(shift) if wantarray;
-        for ($body->get(shift)) {
-            return $_ if $_->upload;
-        }
-    }
-    return map {$_->upload ? $_->name : () } values %$body;
-}
-
-
-package APR::Request::CGI::Upload;
-use APR::Request::Param;
-push our @ISA, "APR::Request::Param";
-
-sub type {}
-sub filename {}
-sub link {}
-sub fh {}
-sub tempname {}
-sub io {}
-sub slurp {}




Mime
View raw message