httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <joe+gm...@sunstarsys.com>
Subject thaw() isn't a class method
Date Thu, 29 Sep 2005 07:20:19 GMT

I didn't intend for APR::Request::Cookie::thaw() to be a 
class method, but somehow I documented it that way.  Any 
objections to my applying this patch?

Index: glue/perl/xsbuilder/APR/Request/Cookie/Cookie.pm
===================================================================
--- glue/perl/xsbuilder/APR/Request/Cookie/Cookie.pm	(revision 291369)
+++ glue/perl/xsbuilder/APR/Request/Cookie/Cookie.pm	(working copy)
@@ -20,7 +20,6 @@
 sub freeze { return $_[1] }
 sub thaw {
     my $obj = shift;
-    return shift if @_;
     return "$obj";
 }
 
Index: glue/perl/xsbuilder/APR/Request/Cookie/Cookie.pod
===================================================================
--- glue/perl/xsbuilder/APR/Request/Cookie/Cookie.pod	(revision 291369)
+++ glue/perl/xsbuilder/APR/Request/Cookie/Cookie.pod	(working copy)
@@ -145,10 +145,10 @@
 
 =head2 thaw
 
-    APR::Request::Cookie->thaw($value)
+    $cookie->thaw()
 
-Class method that reverses C<< freeze() >>;
-here it returns $value unmodified.
+Reverses C<< freeze() >>; here it simply returns 
+$cookie->value since freeze() is a noop.
 
 
 


-- 
Joe Schaefer


Mime
View raw message