httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Schaefer <>
Subject cleaning up url_decode
Date Mon, 22 Aug 2005 01:11:59 GMT

In its current form, the internal url_decode() function is a total mess.
Besides simple url-decoding, it does charset divination. It turns out to 
be a lot cleaner to do the divination *after* decoding (not *during*), 
so I'd like to propose a new function

apreq_charset_t apreq_divine_charset (unsigned const char *s, apr_size_t slen)

that does the same logic, but on the decoded string.

The current APIs for apreq_decode and apreq_decodev don't need to change
because of this (only one current test result needs "fixing").

Joe Schaefer

View raw message