httpd-apreq-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip M. Gollucci" <>
Subject Re: cleaning up url_decode
Date Mon, 22 Aug 2005 15:45:58 GMT
Joe Schaefer wrote:
> In its current form, the internal url_decode() function is a total mess.
> Besides simple url-decoding, it does charset divination. It turns out to 
> be a lot cleaner to do the divination *after* decoding (not *during*), 
> so I'd like to propose a new function
> apreq_charset_t apreq_divine_charset (unsigned const char *s, apr_size_t slen)
> that does the same logic, but on the decoded string.
> The current APIs for apreq_decode and apreq_decodev don't need to change
> because of this (only one current test result needs "fixing").
I agree with the idea...

Kudos on the function name.

     What doesn't kill us can only make us stronger.
                 Nothing is impossible.
Philip M. Gollucci ( 301.254.5198
Consultant /
Senior Developer / Liquidity Services, Inc.

View raw message